| commit | 33106877277e6bfb3944b5b65b5d700fb781764e | [log] [tgz] |
|---|---|---|
| author | Tom de Goede <tom.degoede@afas.nl> | Tue May 19 08:35:41 2020 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue May 19 08:36:55 2020 -0700 |
| tree | 68df7ca68129d7a280a6a8b5c5d515019d1a2490 | |
| parent | 09d1370d4f6d334d24059a9fe3b2f960658733d1 [diff] |
Fix windows --watchfs As discussed in #1931 --watchfs was made a no-op on windows in d04d7baa1605c8c3a637255bd61c00dba73ad800. The reason for this is that it will hold locks for the (parent-directories of) directories it is watching. Since we recursively register the watcher this leads to locks on folders we do not want to be locked. The issue is known and tracked at https://bugs.openjdk.java.net/browse/JDK-6972833 but is marked as a Won't Fix. The suggested fix is to instead use ExtendedWatchEventModifier.FILE_TREE which allows a single WatchKey to recursively watch a folder on windows. This pull request implements the FILE_TREE flag for the root folder that is being watched, and disables the registration of the recursive folders. I have tried to keep the change as small as possible, but I can imagine that we wish to separate this logic to dedicated windows class similar to the OSX variant. Fixes #1931 Closes #11334. PiperOrigin-RevId: 312285715
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
