commit 3b5d5d22f27fa8d9297fdf39b5b18d1bb6ea8e57
author Janak Ramakrishnan <janakr@google.com> Fri May 13 21:14:56 2016 +0000
committer Kristina Chodorow <kchodorow@google.com> Mon May 16 15:16:42 2016 +0000
tree e0503976694a62a8365403abc888f33c76fb8e3a
parent a56c1f4a1b47131b6d366a658f1f1e5abe0cdf3d

Stop converting temporary direct deps to a set. In almost all cases, this conversion is unnecessary and wasteful. In the remaining cases, the set conversion can be explicit.

--
MOS_MIGRATED_REVID=122294939

src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java b/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
index 7b885b8..56bcd05 100644
--- a/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
+++ b/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
@@ -415,10 +415,11 @@
   public synchronized Iterable<SkyKey> getAllDirectDepsForIncompleteNode() {
     Preconditions.checkState(!isDone(), this);
     if (!isDirty()) {
-      return getTemporaryDirectDeps();
+      return Iterables.concat(getTemporaryDirectDeps());
     } else {
       return Iterables.concat(
-          getTemporaryDirectDeps(), buildingState.getAllRemainingDirtyDirectDeps());
+          Iterables.concat(getTemporaryDirectDeps()),
+          buildingState.getAllRemainingDirtyDirectDeps());
     }
   }
 
@@ -428,7 +429,7 @@
   }
 
   @Override
-  public synchronized Set<SkyKey> getTemporaryDirectDeps() {
+  public synchronized GroupedList<SkyKey> getTemporaryDirectDeps() {
     Preconditions.checkState(!isDone(), "temporary shouldn't be done: %s", this);
     return buildingState.getDirectDepsForBuild();
   }