commit 3beaaaf23e4f6e9071ef7eabced7d64513573e80
author Googler <adgar@google.com> Thu Apr 25 18:37:43 2024 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Apr 25 18:39:23 2024 -0700
tree 00f42c4cf7cb1ecfae9b7aa4541669529341bc2a
parent 49850f89f86ab25d32a163fc5e032c4abec45549

Use regexp to use JEP394 where IntelliJ inspection fails.

PCRE regexp: `(\w+) instanceof ([A-Z]\w+)((\)|;)?.*\n.*)\(\2\) \1`

Replaced with: `$1 instanceof $2 roflmao$3roflmao`

Then processed with a Ruby script to rewrite `roflmao` with the name of the class, lowercasing the first letter.

Then I used the IntelliJ "Remove unnecessary parentheses" inspection.

#jdk21 #jep391

PiperOrigin-RevId: 628255645
Change-Id: I74031b97efa72636fdccb1c2473bc3a5f92ad7e9

src/main/java/com/google/devtools/build/lib/skyframe/RecursiveFilesystemTraversalFunction.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/RecursiveFilesystemTraversalFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/RecursiveFilesystemTraversalFunction.java
index 42e0cd9..0151bc0 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/RecursiveFilesystemTraversalFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/RecursiveFilesystemTraversalFunction.java
@@ -335,8 +335,8 @@
 
         if (value instanceof FileArtifactValue || value instanceof TreeArtifactValue) {
           fsVal = (HasDigest) value;
-        } else if (value instanceof ActionExecutionValue) {
-          fsVal = ((ActionExecutionValue) value).getExistingFileArtifactValue(artifact);
+        } else if (value instanceof ActionExecutionValue actionExecutionValue) {
+          fsVal = actionExecutionValue.getExistingFileArtifactValue(artifact);
         } else {
           return NON_EXISTENT_FILE_INFO;
         }