commit 3ca2468ddd3d34606e34ee08b8698d4ddce84dfe
author janakr <janakr@google.com> Wed Apr 01 09:12:03 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Apr 01 09:13:34 2020 -0700
tree 554dfa7f50983dd1fe116a39ae4ac2e3f1a67fe1
parent 8109991630abfcc28dd8bb22e39bc315627a553f

Remove superfluous BuildEventId Java class. The protobuf is just as good, and it reduces complexity to not have these wrapper classes floating around.

Probably will have no noticeable effect on performance/memory, but can't hurt.

PiperOrigin-RevId: 304197948

src/main/java/com/google/devtools/build/lib/analysis/AnalysisFailureEvent.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/AnalysisFailureEvent.java b/src/main/java/com/google/devtools/build/lib/analysis/AnalysisFailureEvent.java
index e34beea..ea0e769 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/AnalysisFailureEvent.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/AnalysisFailureEvent.java
@@ -19,8 +19,9 @@
 import com.google.common.collect.Iterables;
 import com.google.devtools.build.lib.buildeventstream.BuildEvent;
 import com.google.devtools.build.lib.buildeventstream.BuildEventContext;
-import com.google.devtools.build.lib.buildeventstream.BuildEventId;
+import com.google.devtools.build.lib.buildeventstream.BuildEventIdUtil;
 import com.google.devtools.build.lib.buildeventstream.BuildEventStreamProtos;
+import com.google.devtools.build.lib.buildeventstream.BuildEventStreamProtos.BuildEventId;
 import com.google.devtools.build.lib.buildeventstream.GenericBuildEvent;
 import com.google.devtools.build.lib.buildeventstream.NullConfiguration;
 import com.google.devtools.build.lib.causes.Cause;
@@ -75,12 +76,13 @@
 
   @Override
   public BuildEventId getEventId() {
-    return BuildEventId.targetCompleted(failedTarget.getLabel(), configuration);
+    return BuildEventIdUtil.targetCompleted(failedTarget.getLabel(), configuration);
   }
 
   @Override
   public Collection<BuildEventId> getChildrenEvents() {
-    return ImmutableList.copyOf(Iterables.transform(rootCauses.toList(), BuildEventId::fromCause));
+    return ImmutableList.copyOf(
+        Iterables.transform(rootCauses.toList(), cause -> cause.getIdProto()));
   }
 
   @Override