Ninja symlink outputs: fix working_dir and output_root path handling
symlink_outputs in Ninja files are always created relative to the working directory. If the working directory is /path/to/foo, and the output root is /path/to/foo/out, the symlink_outputs values in the Ninja file will be "out/path/to/symlink".
Currently, the code that creates symlink artifacts tries to get the relative path of the symlink from the output root ("out/path/to/symlink".relativeTo("out") == "path/to/symlink"), and tries to find that in a set of paths that *do* contain the output root as the prefix ("out/path/to/symlink"), since the set contains path relative to the *working directory*. This causes failures.
Instead, use the path relative to the working directory while checking the symlink outputs set instead, preserving the output root path prefix.
Added a test case where the working dir is the top level directory, and "out" as the toplevel_output_directory and ninja_graph.output_root, emulating the environment where this bug was found.
Closes #12326.
PiperOrigin-RevId: 338441118
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
