commit 3ebf658cba43bbab1efc36518f0795a7d65e2d46
author Ed Schouten <eschouten@apple.com> Fri Mar 12 06:18:17 2021 -0800
committer Copybara-Service <copybara-worker@google.com> Fri Mar 12 06:19:43 2021 -0800
tree 141476c1d37ea1d2cfe3b886c519ca9274823597
parent 03fd5419ab4570160542b3ea85433d84a38628ab

Prevent a crash when using --repo_env=VAR without a value

The --repo_env option is documented in the same way as --action_env. In
addition to allowing you to set explicit values, you can also use it to
explicitly pick values from the environment in which Bazel was invoked.
Unfortunately, this causes a null pointer exception in Starlark due to a
null string stored as a map value.

This change extends the logic of converting --repo_env to a map to take
null values into account. When null, the value is loaded from the
current environment. This behaviour is useful in case you want to do
something like this:

--incompatible_strict_action_env --action_env=PATH=... --repo_env=PATH

This allows you to run build actions with a strict value for $PATH (e.g.,
to get a decent action cache hit rate in case of remote execution),
while still allowing repository_ctx.which() to find tools on the host
system using $PATH.

Closes #12886.

PiperOrigin-RevId: 362506900