| commit | 3f602f2abdeccb353dfbb8cfed91fb5c9bd6dfc5 | [log] [tgz] |
|---|---|---|
| author | adonovan <adonovan@google.com> | Wed Jan 08 10:28:10 2020 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Jan 08 10:29:20 2020 -0800 |
| tree | 3bfe9a1cb7ca032b7e1987dc0964ea393f137074 | |
| parent | d0d8e84661da99f091efc0c25dc82b320357ff96 [diff] |
bazel syntax: optimize calls to built-in methods This change rewrites CallUtils.convertStarlarkArgumentsToJavaMethodArguments, now called BuiltinCallable.getArgumentVector, to process arguments in three steps---positional, named, defaults---avoiding all memory allocation except for the argument vector itself. Evaluation of parameter default value expressions has been moved into ParamDescriptor, so that concurrent hash map lookups are avoided. Also, the error messages have been improved in many ways - they are more concise, and don't dump the whole signature. - they state facts before expectations. - they are better phrased (subject first, emphasis last). - the called function is always named, but simply, not in fussy detail. - the numbers of accepted parameters are stated, when relevant. - the incorrect type is shown after a failed type check. - unexpected keywords are spell-checked. - plurals are correct. The logic is somewhat simpler. Except in lib.syntax itself, test expectations of these error messages have been edited down to the crucial parts, for robustness. This is a breaking API change for copybara. BEGIN_PUBLIC bazel syntax: optimize calls to built-in methods END_PUBLIC PiperOrigin-RevId: 288725155
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
