Fix broken tests. -- MOS_MIGRATED_REVID=102134151
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/AspectWithParameters.java b/src/main/java/com/google/devtools/build/lib/analysis/AspectWithParameters.java index 0cffc4c..be39f14 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/AspectWithParameters.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/AspectWithParameters.java
@@ -13,6 +13,7 @@ // limitations under the License. package com.google.devtools.build.lib.analysis; +import com.google.common.base.Preconditions; import com.google.devtools.build.lib.packages.AspectParameters; import java.util.Objects; @@ -31,6 +32,7 @@ public AspectWithParameters( Class<? extends ConfiguredAspectFactory> aspect, AspectParameters parameters) { + Preconditions.checkNotNull(parameters); this.aspectFactory = aspect; this.parameters = parameters; }
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java b/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java index a7fff98..41f6ecd 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
@@ -50,6 +50,7 @@ import com.google.devtools.build.lib.events.Event; import com.google.devtools.build.lib.events.EventHandler; import com.google.devtools.build.lib.events.StoredEventHandler; +import com.google.devtools.build.lib.packages.AspectParameters; import com.google.devtools.build.lib.packages.Attribute; import com.google.devtools.build.lib.packages.NoSuchPackageException; import com.google.devtools.build.lib.packages.NoSuchTargetException; @@ -878,7 +879,7 @@ ListMultimap<Attribute, Dependency> depNodeNames; try { depNodeNames = resolver.dependentNodeMap(ctNode, configurations.getHostConfiguration(), - /*aspect=*/null, /*aspectParameters=*/null, getConfigurableAttributeKeys(ctNode)); + /*aspect=*/null, AspectParameters.EMPTY, getConfigurableAttributeKeys(ctNode)); } catch (EvalException e) { throw new IllegalStateException(e); }
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java b/src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java index f8ec20a..debf6f4 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java
@@ -504,7 +504,7 @@ Set<ConfigMatchingProvider> configConditions) { try { return ImmutableSet.copyOf(dependentNodeMap(node, hostConfig, /*aspect=*/null, - /*aspectParameters=*/null, configConditions).values()); + AspectParameters.EMPTY, configConditions).values()); } catch (EvalException e) { throw new IllegalStateException(e); } @@ -598,7 +598,7 @@ private void visitRule(Rule rule, ListMultimap<Attribute, LabelAndConfiguration> labelMap, ListMultimap<Attribute, Dependency> outgoingEdges) { - visitRule(rule, /*aspect=*/null, /*aspectParameters=*/null, labelMap, outgoingEdges); + visitRule(rule, /*aspect=*/null, AspectParameters.EMPTY, labelMap, outgoingEdges); } private void visitRule(Rule rule, AspectDefinition aspect, AspectParameters aspectParameters,
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/PostConfiguredTargetFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/PostConfiguredTargetFunction.java index d14bf46..315d965 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/PostConfiguredTargetFunction.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/PostConfiguredTargetFunction.java
@@ -26,6 +26,7 @@ import com.google.devtools.build.lib.analysis.TargetAndConfiguration; import com.google.devtools.build.lib.analysis.config.BuildConfiguration; import com.google.devtools.build.lib.analysis.config.ConfigMatchingProvider; +import com.google.devtools.build.lib.packages.AspectParameters; import com.google.devtools.build.lib.packages.Attribute; import com.google.devtools.build.lib.packages.RawAttributeMapper; import com.google.devtools.build.lib.packages.Rule; @@ -101,7 +102,7 @@ BuildConfiguration hostConfiguration = buildViewProvider.getSkyframeBuildView().getHostConfiguration(ct.getConfiguration()); deps = resolver.dependentNodeMap(ctgValue, hostConfiguration, /*aspect=*/null, - /*aspectParameters=*/null, configConditions); + AspectParameters.EMPTY, configConditions); if (ct.getConfiguration() != null && ct.getConfiguration().useDynamicConfigurations()) { deps = ConfiguredTargetFunction.trimConfigurations(env, ctgValue, deps, hostConfiguration, ruleClassProvider);