| commit | 338829f2633e91ae0492ee4169446465e10b5994 | [log] [tgz] |
|---|---|---|
| author | Artem Zinnatullin <ceo@artemzin.com> | Mon Aug 05 06:46:28 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Aug 05 06:47:34 2019 -0700 |
| tree | 706330966a630deaf1e9614993c2ee9717aebbf0 | |
| parent | 299655ee2600874667fa9e21e6d1e598bb011b56 [diff] |
Fix retrying of SocketTimeoutExceptions in HttpConnector As part of investigation of #8974 I found that recent change 982e0b8398ea26ce1f5323b9e928990ae8845473 broke retries of `SocketTimeoutException` in `HttpConnector`, intention of that change was good but lack of tests resulted in broken logic. IntelliJ highlights the problem ? branch with `instanceof SocketTimeoutException` would have never been executed: <img width="764" alt="Screen Shot 2019-07-29 at 3 26 11 PM" src="https://user-images.githubusercontent.com/967132/62089179-d7bfa400-b21c-11e9-882a-1c1fe1fcb683.png"> --- This PR adds missing tests and fixes the logic to still present `SocketTimeoutException` as `IOException` for upstream consumers while handling it properly internally in the `HttpConnector`. Closes #9008. PiperOrigin-RevId: 261675244
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel only rebuilds what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
Bazel is released in ‘Beta’. See the product roadmap to learn about the path toward a stable 1.0 release.
