| commit | c68908ff3f916f07a005f425fe83000fb683b225 | [log] [tgz] |
|---|---|---|
| author | nharmata <nharmata@google.com> | Fri Dec 10 11:14:41 2021 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Dec 10 11:16:00 2021 -0800 |
| tree | b945b980104a0dfd9fdafb3cd7bf119d8c9e3fc2 | |
| parent | 348ecad259a1680d6c7a1b09e52a5c202fb18749 [diff] |
Replace the per-`SkyKey` caches used by `PackageFunction` with the new `SkyKeyComputeState` mechanism. The new mechanism is just as good but doesn't have the downsides of the explicit per-`SkyKey` caches. See the "Background and motivation" section of the description of https://github.com/bazelbuild/bazel/commit/ed279ab4fa2d4356be00b54266f56edcc5aeae78. This CL is expected to be performance neutral in all situations. N.B. `PackageFunctionTest#testDiscrepancyBetweenGlobbingErrors` was ironically [very subtly] making use of the fact that the entry inside of `packageFunctionCache` for a `PackageValue` node with a dep in error does *not* get cleared inside of a `--nokeep_going` evaluation. Since this CL changes that behavior I had to change the test case to use a `--keep_going` evaluation in order to exercise the situation it wants to exercise. PiperOrigin-RevId: 415564015
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
