| commit | 3a5d20098e5058040e958d807be2fbbf8a2f1f46 | [log] [tgz] |
|---|---|---|
| author | Michajlo Matijkiw <michajlo@google.com> | Wed Sep 14 16:17:59 2016 +0000 |
| committer | Dmitry Lomov <dslomov@google.com> | Wed Sep 14 16:57:10 2016 +0000 |
| tree | 9bea3e2eaf1034cfdbe45977d68b4515f1812cc9 | |
| parent | bbb47b6ed0adac08c118999fda83a96e353e7f80 [diff] |
Move request cancellation off the dispatching thread Because we're running our server in a directExecutor the request handling thread must not block. However in the case of interrupting the command thread we can block in at least two ways, one not so obvious. The obvious way is synchronizing on runningCommands. The not obvious way is that interrupting a thread has some tricky locking involved which can get tangled up with operations happening in other threads, which may wind up being blocked on the dispatcher thread being active. More concretely, a thread producing output for RpcOutputStream may block as a result of the backpressure mechanisms we have in place. If this winds up blocking in an opportune way, such that it holds some lock the cancellation thread needs to make progress, we had a deadlock, since the cancellation thread was preventing output from being consumed. -- MOS_MIGRATED_REVID=133134743
{Fast, Correct} - Choose two
Bazel is a build tool that builds code quickly and reliably. It is used to build the majority of Google‘s software, and thus it has been designed to handle build problems present in Google’s development environment, including:
A massive, shared code repository, in which all software is built from source. Bazel has been built for speed, using both caching and parallelism to achieve this. Bazel is critical to Google's ability to continue to scale its software development practices as the company grows.
An emphasis on automated testing and releases. Bazel has been built for correctness and reproducibility, meaning that a build performed on a continuous build machine or in a release pipeline will generate bitwise-identical outputs to those generated on a developer's machine.
Language and platform diversity. Bazel's architecture is general enough to support many different programming languages within Google, and can be used to build both client and server software targeting multiple architectures from the same underlying codebase.
Find more background about Bazel in our FAQ.