commit 46e5e41fd52239baba882152f7423c89c58d8242
author Nathan Harmata <nharmata@google.com> Wed Jun 29 16:18:10 2016 +0000
committer Dmitry Lomov <dslomov@google.com> Thu Jun 30 11:40:55 2016 +0000
tree c1ccc5a124e1496065b4bf550f39728e7539cad8
parent af2ea37ceab2300a6d40afe65c1e333dfbaa0a11

Cap depserver log lines of blaze stderr lines at 1000 chars. Implement both this and commit 116c2f6724718fc408e0c73c9026d89281c75e87 using Guava's Ascii#truncate.

--
MOS_MIGRATED_REVID=126198762

src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java

diff --git a/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java b/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java
index 834b69d..1865381 100644
--- a/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java
+++ b/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java
@@ -14,6 +14,7 @@
 package com.google.devtools.build.lib.query2;
 
 import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Ascii;
 import com.google.common.base.Function;
 import com.google.common.base.Predicate;
 import com.google.common.base.Predicates;
@@ -231,13 +232,6 @@
     ExecutorUtil.interruptibleShutdown(threadPool);
   }
 
-  private static String getLogString(QueryExpression queryExpression) {
-    String queryExpressionString = queryExpression.toString();
-    return queryExpressionString.length() <= MAX_QUERY_EXPRESSION_LOG_CHARS
-        ? queryExpressionString
-        : queryExpressionString.substring(0, MAX_QUERY_EXPRESSION_LOG_CHARS) + "...[truncated]";
-  }
-
   @Override
   public QueryExpression transformParsedQuery(QueryExpression queryExpression) {
     // Transform each occurrence of an expressions of the form 'rdeps(<universeScope>, <T>)' to
@@ -271,8 +265,10 @@
     QueryExpression transformedQueryExpression = queryExpression.getMapped(rdepsToAllRDepsMapper);
     LOG.info(String.format(
         "transformed query [%s] to [%s]",
-        getLogString(queryExpression),
-        getLogString(transformedQueryExpression)));
+        Ascii.truncate(
+            queryExpression.toString(), MAX_QUERY_EXPRESSION_LOG_CHARS, "[truncated]"),
+        Ascii.truncate(
+            transformedQueryExpression.toString(), MAX_QUERY_EXPRESSION_LOG_CHARS, "[truncated]")));
     return transformedQueryExpression;
   }