| commit | d8c27bfcd37a74dfbf1bdb9a1e3df13af8360a01 | [log] [tgz] |
|---|---|---|
| author | Googler <tjgq@google.com> | Thu Apr 18 05:55:04 2024 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Apr 18 05:57:16 2024 -0700 |
| tree | f29e64d239f4922e5dc9b10d1f67a05d6756bed7 | |
| parent | 5a94ac3473a812a977f6ba3a4cfa4d5df6cbea55 [diff] |
Rework the logic for writing virtual inputs, in an attempt to fix a race condition observed at Google. I suspect that the race condition is due to LocalSpawnRunner writing virtual inputs (specifically, the PathActionInputs created by BinTools) in a non-atomic manner, thus racing with other spawn runners writing the same input. It's also not clear to me that, for ParamFileActionInputs, it suffices to handle the dynamic execution case by providing a per-branch suffix. This rests on the assumption that no ParamFileActionInputs are shared between actions, but while this might be true today, I'd rather not rely on it to hold indefinitely. Instead, let's always use a globally unique suffix, adapting the preexisting logic in SandboxHelpers. PiperOrigin-RevId: 626006017 Change-Id: I2c6d81a4db046d7f85832e7675835141ed21d027
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
