Make SeparatedOptionListConverter declare that it returns an ImmutableList.
PiperOrigin-RevId: 435790755
diff --git a/src/main/java/com/google/devtools/common/options/Converters.java b/src/main/java/com/google/devtools/common/options/Converters.java
index 56bc63c..15e8b47 100644
--- a/src/main/java/com/google/devtools/common/options/Converters.java
+++ b/src/main/java/com/google/devtools/common/options/Converters.java
@@ -250,8 +250,8 @@
return buf.length() == 0 ? "nothing" : buf.toString();
}
- public static class SeparatedOptionListConverter implements Converter<List<String>> {
-
+ /** Converter for a list of options, separated by some separator character. */
+ public static class SeparatedOptionListConverter implements Converter<ImmutableList<String>> {
private final String separatorDescription;
private final Splitter splitter;
private final boolean allowEmptyValues;
@@ -264,8 +264,8 @@
}
@Override
- public List<String> convert(String input) throws OptionsParsingException {
- List<String> result =
+ public ImmutableList<String> convert(String input) throws OptionsParsingException {
+ ImmutableList<String> result =
input.isEmpty() ? ImmutableList.of() : ImmutableList.copyOf(splitter.split(input));
if (!allowEmptyValues && result.contains("")) {
// If the list contains exactly the empty string, it means an empty value was passed and we
