Use const char a[] if sizeof is used to get length
`memcmp(msys_display_name, value, sizeof(msys_display_name)` try to get length of `msys_display_name` with `sizeof`, but `msys_display_name` is declared as `const char*` pointer, so `sizeof` will return the size of pointer (8-bytes) instead of actual length of string. Declare string as `const char msys_display_name[]` will fix this.
Found by Clang's `-Wsizeof-pointer-memaccess`.
/cc @dslomov
Closes #5476.
PiperOrigin-RevId: 202903566
diff --git a/src/main/cpp/blaze_util_windows.cc b/src/main/cpp/blaze_util_windows.cc
index d41a2f4..3bd2d81 100644
--- a/src/main/cpp/blaze_util_windows.cc
+++ b/src/main/cpp/blaze_util_windows.cc
@@ -1093,7 +1093,7 @@
// MSYS2 installer writes its registry into HKCU, although documentation
// (https://msdn.microsoft.com/en-us/library/ms954376.aspx)
// clearly states that it should go to HKLM.
- static const char* const key =
+ static constexpr const char key[] =
"Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall";
if (RegOpenKeyExA(HKEY_CURRENT_USER, // _In_ HKEY hKey,
key, // _In_opt_ LPCTSTR lpSubKey,
@@ -1111,7 +1111,7 @@
// we enumerate all keys under
// HKCU\Software\Microsoft\Windows\CurrentVersion\Uninstall and find the first
// with MSYS2 64bit display name.
- static const char* const msys_display_name = "MSYS2 64bit";
+ static constexpr const char msys_display_name[] = "MSYS2 64bit";
DWORD n_subkeys;
if (RegQueryInfoKey(h_uninstall, // _In_ HKEY hKey,
@@ -1220,7 +1220,7 @@
HKEY h_GitOnWin_uninstall;
// Well-known registry key for Git-on-Windows.
- static const char* const key =
+ static constexpr const char key[] =
"Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Git_is1";
if (RegOpenKeyExA(HKEY_LOCAL_MACHINE, // _In_ HKEY hKey,
key, // _In_opt_ LPCTSTR lpSubKey,
