| commit | 4d1d0b50ff2c4a789f715a12fb4bafe52d710f30 | [log] [tgz] |
|---|---|---|
| author | laurentlb <laurentlb@google.com> | Fri Aug 31 12:29:35 2018 -0700 |
| committer | Copybara-Service <copybara-piper@google.com> | Fri Aug 31 12:31:18 2018 -0700 |
| tree | 7d5673b194d5085471bac969bc4d929692dad522 | |
| parent | f89e063584564a090ab64c42fb8d4a253398c36f [diff] |
Add a linter check for native.package() Using it in bzl files can make the code harder to maintain. https://github.com/bazelbuild/bazel/issues/5939 RELNOTES: None. PiperOrigin-RevId: 211126156
diff --git a/src/tools/skylark/java/com/google/devtools/skylark/skylint/DeprecatedApiChecker.java b/src/tools/skylark/java/com/google/devtools/skylark/skylint/DeprecatedApiChecker.java index 818796e..6135bd7 100644 --- a/src/tools/skylark/java/com/google/devtools/skylark/skylint/DeprecatedApiChecker.java +++ b/src/tools/skylark/java/com/google/devtools/skylark/skylint/DeprecatedApiChecker.java
@@ -114,6 +114,10 @@ "ctx.outputs.executable", "See https://docs.bazel.build/versions/master/skylark/" + "rules.html#executable-rules-and-test-rules") + .put( + "native.package", + "Call package() in the BUILD file instead. " + + "See https://github.com/bazelbuild/bazel/issues/5939.") .build(); private void checkDeprecated(Expression node) {
diff --git a/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/DeprecatedApiCheckerTest.java b/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/DeprecatedApiCheckerTest.java index cafe898..4d34ad3 100644 --- a/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/DeprecatedApiCheckerTest.java +++ b/src/tools/skylark/javatests/com/google/devtools/skylark/skylint/DeprecatedApiCheckerTest.java
@@ -48,6 +48,8 @@ .contains("1:5-1:26: ctx.outputs.executable is deprecated"); Truth.assertThat(findIssues("css_filetype = FileType(['.css'])").toString()) .contains("1:16-1:23: FileType is deprecated"); + Truth.assertThat(findIssues("native.package()").toString()) + .contains("Call package() in the BUILD file instead"); Truth.assertThat(findIssues("ctx.actions()")).isEmpty(); }