| commit | 4d382b73d98c1910245dc89f8e3af010f0d56494 | [log] [tgz] |
|---|---|---|
| author | ilist <ilist@google.com> | Tue May 10 23:54:01 2022 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue May 10 23:55:02 2022 -0700 |
| tree | c799946d7d76e98ffccd20225564d124386efccd | |
| parent | 075c5a33d34eed5fc56dd65a5e542df9180f6069 [diff] |
Cache StarlarkDefinedAspect AspectDefinitons While replacing `java_lite_proto_library` native implementation with Starlarks, a significant regression occurred in retained heap. Inspecting the heap, there were more instances of AspectDefinition and instances of classes used within it. Further inspection of unrelated AspectDefinition showed, that an instance is created for every target that uses a rule with a Starlark aspect. The native aspects already used a cache - implemented in https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/packages/Aspect.java;l=47-54;drc=a4063f6928965e3cc55a18a6b3efff032abb7311 Implement similar cache except for using `weakKeys` (because moving to a different part of the depot, should free those aspects). I considered putting the cache into the same location (`Aspect` class), but that would require refactoring signature of `Aspect.forStarlark` method and there were some preliminary problems with `StarlarkNativeAspect`-s. PiperOrigin-RevId: 447918213
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
