commit 4dd6f00db129c2082cedde84e20d23e852a0a2e6
author Googler <noreply@google.com> Tue Mar 27 08:15:39 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Tue Mar 27 08:17:53 2018 -0700
tree 0bc47d5a0d5be2fb7659c64649b0ce86681185cb
parent 0cafdfef8dcbde4aa556c93f05be85594c67656f

Ensure Runner name is always set.

RELNOTES: None.
PiperOrigin-RevId: 190617155

src/test/java/com/google/devtools/build/lib/actions/ActionResultTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/actions/ActionResultTest.java b/src/test/java/com/google/devtools/build/lib/actions/ActionResultTest.java
index 207df55..820261a 100644
--- a/src/test/java/com/google/devtools/build/lib/actions/ActionResultTest.java
+++ b/src/test/java/com/google/devtools/build/lib/actions/ActionResultTest.java
@@ -50,6 +50,7 @@
             .setNumBlockInputOperations(20)
             .setNumInvoluntaryContextSwitches(30)
             .setStatus(SpawnResult.Status.SUCCESS)
+            .setRunnerName("test")
             .build();
     List<SpawnResult> spawnResults = ImmutableList.of(spawnResult);
     ActionResult actionResult = ActionResult.create(spawnResults);
@@ -73,6 +74,7 @@
             .setNumBlockInputOperations(20)
             .setNumInvoluntaryContextSwitches(30)
             .setStatus(SpawnResult.Status.SUCCESS)
+            .setRunnerName("test")
             .build();
     SpawnResult spawnResult2 =
         new SpawnResult.Builder()
@@ -83,6 +85,7 @@
             .setNumBlockInputOperations(200)
             .setNumInvoluntaryContextSwitches(300)
             .setStatus(SpawnResult.Status.SUCCESS)
+            .setRunnerName("test")
             .build();
     SpawnResult spawnResult3 =
         new SpawnResult.Builder()
@@ -93,6 +96,7 @@
             .setNumBlockInputOperations(2000)
             .setNumInvoluntaryContextSwitches(3000)
             .setStatus(SpawnResult.Status.SUCCESS)
+            .setRunnerName("test")
             .build();
     List<SpawnResult> spawnResults = ImmutableList.of(spawnResult1, spawnResult2, spawnResult3);
     ActionResult actionResult = ActionResult.create(spawnResults);
@@ -108,11 +112,20 @@
   @Test
   public void testCumulativeCommandExecutionTime_ManyEmptySpawnResults() {
     SpawnResult spawnResult1 =
-        new SpawnResult.Builder().setStatus(SpawnResult.Status.SUCCESS).build();
+        new SpawnResult.Builder()
+            .setStatus(SpawnResult.Status.SUCCESS)
+            .setRunnerName("test")
+            .build();
     SpawnResult spawnResult2 =
-        new SpawnResult.Builder().setStatus(SpawnResult.Status.SUCCESS).build();
+        new SpawnResult.Builder()
+            .setStatus(SpawnResult.Status.SUCCESS)
+            .setRunnerName("test")
+            .build();
     SpawnResult spawnResult3 =
-        new SpawnResult.Builder().setStatus(SpawnResult.Status.SUCCESS).build();
+        new SpawnResult.Builder()
+            .setStatus(SpawnResult.Status.SUCCESS)
+            .setRunnerName("test")
+            .build();
     List<SpawnResult> spawnResults = ImmutableList.of(spawnResult1, spawnResult2, spawnResult3);
     ActionResult actionResult = ActionResult.create(spawnResults);
     assertThat(actionResult.cumulativeCommandExecutionWallTime()).isEmpty();
@@ -130,16 +143,19 @@
         new SpawnResult.Builder()
             .setUserTime(Duration.ofMillis(2))
             .setStatus(SpawnResult.Status.SUCCESS)
+            .setRunnerName("test")
             .build();
     SpawnResult spawnResult2 =
         new SpawnResult.Builder()
             .setUserTime(Duration.ofMillis(3))
             .setStatus(SpawnResult.Status.SUCCESS)
+            .setRunnerName("test")
             .build();
     SpawnResult spawnResult3 =
         new SpawnResult.Builder()
             .setUserTime(Duration.ofMillis(4))
             .setStatus(SpawnResult.Status.SUCCESS)
+            .setRunnerName("test")
             .build();
     List<SpawnResult> spawnResults = ImmutableList.of(spawnResult1, spawnResult2, spawnResult3);
     ActionResult actionResult = ActionResult.create(spawnResults);
@@ -153,16 +169,19 @@
         new SpawnResult.Builder()
             .setSystemTime(Duration.ofMillis(33))
             .setStatus(SpawnResult.Status.SUCCESS)
+            .setRunnerName("test")
             .build();
     SpawnResult spawnResult2 =
         new SpawnResult.Builder()
             .setSystemTime(Duration.ofMillis(7))
             .setStatus(SpawnResult.Status.SUCCESS)
+            .setRunnerName("test")
             .build();
     SpawnResult spawnResult3 =
         new SpawnResult.Builder()
             .setSystemTime(Duration.ofMillis(2))
             .setStatus(SpawnResult.Status.SUCCESS)
+            .setRunnerName("test")
             .build();
     List<SpawnResult> spawnResults = ImmutableList.of(spawnResult1, spawnResult2, spawnResult3);
     ActionResult actionResult = ActionResult.create(spawnResults);

src/test/java/com/google/devtools/build/lib/actions/SpawnResultTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/actions/SpawnResultTest.java b/src/test/java/com/google/devtools/build/lib/actions/SpawnResultTest.java
index 4fedd29..6dccb47 100644
--- a/src/test/java/com/google/devtools/build/lib/actions/SpawnResultTest.java
+++ b/src/test/java/com/google/devtools/build/lib/actions/SpawnResultTest.java
@@ -33,6 +33,7 @@
             .setStatus(SpawnResult.Status.TIMEOUT)
             .setWallTime(Duration.ofSeconds(5))
             .setExitCode(1)
+            .setRunnerName("test")
             .build();
     assertThat(r.getDetailMessage("", "", false, false))
         .contains("(failed due to timeout after 5.00 seconds.)");
@@ -41,7 +42,11 @@
   @Test
   public void getTimeoutMessageNoTime() {
     SpawnResult r =
-        new SpawnResult.Builder().setStatus(SpawnResult.Status.TIMEOUT).setExitCode(1).build();
+        new SpawnResult.Builder()
+            .setStatus(SpawnResult.Status.TIMEOUT)
+            .setExitCode(1)
+            .setRunnerName("test")
+            .build();
     assertThat(r.getDetailMessage("", "", false, false))
         .contains("(failed due to timeout.)");
   }