commit 4e6a28acbe11e50e2c3336d42c8075293e26b0af
author Fabian Meumertzheim <fabian@meumertzhe.im> Thu Oct 10 12:04:57 2024 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Oct 10 12:06:51 2024 -0700
tree 142a7e8abd367480bb024fb601a05c18575b0175
parent d12959c617164671ff9a2606d863e077f6e2932c

Fix version resolution in `AutoloadSymbols`

The logic picked the first instead of the highest version due to a typo.

Closes #23936.

PiperOrigin-RevId: 684528776
Change-Id: Ic61c84ca2f3489e43fc71944824e7e2311543ab9

src/main/java/com/google/devtools/build/lib/packages/AutoloadSymbols.java

diff --git a/src/main/java/com/google/devtools/build/lib/packages/AutoloadSymbols.java b/src/main/java/com/google/devtools/build/lib/packages/AutoloadSymbols.java
index 8968c03..fe1d865 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/AutoloadSymbols.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/AutoloadSymbols.java
@@ -405,7 +405,7 @@
                   toImmutableMap(
                       ModuleKey::name,
                       moduleKey -> moduleKey,
-                      (m1, m2) -> m1.version().compareTo(m2.version()) >= 0 ? m1 : m1));
+                      (m1, m2) -> m1.version().compareTo(m2.version()) >= 0 ? m1 : m2));
       RepositoryMapping repositoryMapping =
           RepositoryMapping.create(
               highestVersions.entrySet().stream()