Replace 'whitelist' with 'allowlist' in Bazel source code.
Phase 1: Rename class, methods, variables, and error messages.
This change still leaves the list locations at hard coded paths to //tools/whitelists. Those may each require a separate migration.
NOTE: We are not considering this a breaking change, even though the error messages might change.
Also: Fix some things that ErrorProne complains about, but only if critique could provide a fix. I don't think that refactoring code to please a strident tricorder test should be part of a renaming CL.
RELNOTES: None
PiperOrigin-RevId: 316394382
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BUILD b/src/main/java/com/google/devtools/build/lib/analysis/BUILD
index 463a645..559b481 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/BUILD
+++ b/src/main/java/com/google/devtools/build/lib/analysis/BUILD
@@ -166,6 +166,7 @@
name = "analysis_cluster",
srcs = [
"AliasProvider.java",
+ "Allowlist.java",
"AnalysisEnvironment.java",
"AnalysisFailureEvent.java",
"AnalysisResult.java",
@@ -217,7 +218,6 @@
"TargetContext.java",
"TopLevelArtifactHelper.java",
"Util.java",
- "Whitelist.java",
"WindowsBatchCommandConstructor.java",
"WindowsPowershellCommandConstructor.java",
"actions/ActionConstructionContext.java",