| commit | 538b1194b2687f97ad9b069b6b41a488d53a5a97 | [log] [tgz] |
|---|---|---|
| author | Xavier Bonaventura <xavibonaventura@gmail.com> | Mon Oct 07 14:00:59 2024 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Oct 07 14:02:35 2024 -0700 |
| tree | 4bca0c4d7f75778cf671b653fc6f4162de8257f6 | |
| parent | 2127e4595b1cad8baae9647dbf3cc5607bc4c8c1 [diff] |
Flip disallow empty glob This PR is to flip the default value of `incompatible_disallow_empty_glob`. This flag is tracked in https://github.com/bazelbuild/bazel/issues/8195 and it is available since Bazel 0.29 from August 2019. Once this is merged, users still can allow empty globs without being explicit setting `--incompatible_disallow_empty_glob=false`. The motivation of the flip is https://github.com/bazel-contrib/SIG-rules-authors/issues/37 and the fact of not keeping an incompatible flag for 4 years without flipping it. What needs to be done before flipping this: - [x] Merge https://github.com/protocolbuffers/upb/pull/584 - [x] Update upb to a version that has the change in https://github.com/protocolbuffers/upb/pull/584 - [x] Merge https://github.com/protocolbuffers/upb/pull/745 - [x] Bring the changes from https://github.com/protocolbuffers/upb/pull/745 to the 21.x branch - [x] Bring the changes from https://github.com/protocolbuffers/upb/commit/e5f26018368b11aab672e8e8bb76513f3620c579 to the 21.x branch (https://github.com/protocolbuffers/upb/pull/781) - [x] Update upb to the latest commit of the 21.x branch (https://github.com/bazelbuild/bazel/pull/16343) - [x] Merge https://github.com/bazelbuild/bazel/pull/15374 - [x] Merge https://github.com/bazelbuild/bazel/pull/15339 - [x] Merge https://github.com/bazelbuild/bazel/pull/15330 - [x] Merge https://github.com/bazelbuild/bazel/pull/16431 - [x] Merge https://github.com/bazelbuild/bazel/pull/16468 - [x] Get green checks for this PR - [ ] Fix failures in downstream projects: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags - [ ] Fix empty globs from IntellIJ Plugin (https://github.com/bazelbuild/intellij) - [ ] Issue: https://github.com/bazelbuild/intellij/issues/4040 - [ ] Android Studio Plugin - [ ] Android Studio Plugin Google - [ ] CLion Plugin - [ ] CLion Plugin Google - [ ] IntelliJ Plugin - [ ] IntelliJ Plugin Aspect - [ ] IntelliJ Plugin Aspect Google - [ ] IntelliJ Plugin Google - [ ] IntelliJ UE Plugin - [ ] IntelliJ UE Plugin Google - Opened PRs - [x] https://github.com/bazelbuild/intellij/pull/4025 - [x] https://github.com/bazelbuild/intellij/pull/4038 - [x] Fix empty globs from Bazel Bench (https://github.com/bazelbuild/bazel-bench) - [ ] https://github.com/bazelbuild/bazel-bench/pull/174 - [x] https://github.com/bazelbuild/bazel-bench/pull/149 - [x] Fix empty globs from Buildfarm (https://github.com/bazelbuild/bazel-buildfarm) - [x] Fix empty globs from Cargo - [x] ~~Fix empty globs from Cartographer (https://github.com/cartographer-project/cartographer)~~ (No longer maintained) - Issue: https://github.com/cartographer-project/cartographer/issues/1908 - PR to enforce it https://github.com/cartographer-project/cartographer/pull/1944 - [x] Fix empty globs from Cloud Robotics Core (https://github.com/googlecloudrobotics/core/) - [x] PR to prevent regresions https://github.com/googlecloudrobotics/core/pull/279 - [ ] Fix empty globs from Envoy - [x] Fix empty globs from FlatBuffers - [x] Fix empty globs from Flogger - [ ] Fix empty globs from Gerrit (https://gerrit.googlesource.com/gerrit.git) - Issue: https://issues.gerritcodereview.com/issues/40011754 - [x] Fix empty globs from :bazel:Protobuf - [x] Fix empty globs from rules_android_ndk - [ ] Fix empty globs from rules_dotnet - [x] Fix empty globs from :bazel:rules_foreign_cc https://github.com/bazelbuild/rules_foreign_cc/issues/974 - [x] Fix empty globs from rules_go - [x] Fix empty globs from rules_haskell https://github.com/tweag/rules_haskell/issues/1827 - [x] Fix empty globs from :bazel:rules_jvm_external - [x] Fix empty globs from rules_kotlin - [x] Fix empty globs from rules_nodejs - [x] Fix empty globs from :bazel:rules_python - [ ] Fix empty globs from rules_rust - [x] Fix empty globs from rules_swift - [x] Fix empty globs from rules_webtesting - [x] Fix empty globs from TensorFlow https://github.com/tensorflow/tensorflow/issues/58155 - [x] https://github.com/tensorflow/tensorflow/pull/58008 - [x] https://github.com/tensorflow/tensorflow/pull/58154 - [x] Fix empty globs from upb RELNOTES[INC]: The flag `--incompatible_disallow_empty_glob` now defaults to true. Closes #15327. PiperOrigin-RevId: 683316885 Change-Id: Id34ffd32a9e979fada9207e475b826a508100ba5
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
