commit 53a87b9b9888092f28ce65c29a4beaef2e3cca7d
author John Cater <jcater@google.com> Tue Aug 01 00:53:39 2017 +0200
committer Dmitry Lomov <dslomov@google.com> Tue Aug 01 12:21:59 2017 +0200
tree 6bf6cfcbd72f6e10a12496d0fb36350864513c68
parent 899211db325872f045db1e061597861d9064064f

Improve error message when requesting an invalid toolchain type from the context.

Fixes #3428.

Change-Id: Ib3f45bc6856651cfb29d338d0b4480ba1dd77cea
PiperOrigin-RevId: 163760940

src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java
index 234ed0b..57b09e2 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java
@@ -278,7 +278,12 @@
         ImmutableList<Label> requiredToolchains = aspect.getDefinition().getRequiredToolchains();
         toolchainContext =
             ToolchainUtil.createToolchainContext(
-                env, requiredToolchains, key.getAspectConfiguration());
+                env,
+                String.format(
+                    "aspect %s applied to %s",
+                    aspect.getDescriptor().getDescription(), target.toString()),
+                requiredToolchains,
+                key.getAspectConfiguration());
       } catch (ToolchainContextException e) {
         // TODO(katre): better error handling
         throw new AspectCreationException(e.getMessage());