commit 54d7d61db1b5261c826cafca42a6d5159974d7c3
author Jakob Buchgraber <buchgr@google.com> Mon Mar 25 08:30:17 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Mar 25 08:32:22 2019 -0700
tree 4a001f8b2e1ef59fdd321182867cd234a83014d8
parent 1b506713a00db0f29b585b2bad88cb1b9c9a7bcc

remote: remove buildAction profiler call

the work done for building an action proto is trivial and not worth to
be included in the json profile. this is a left over from when we used
to build the merkle tree in buildAction, but this is no longer the case.

Closes #7824.

PiperOrigin-RevId: 240144048

src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java

diff --git a/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java b/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java
index 7d9d2bd..6c781eb 100644
--- a/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java
+++ b/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java
@@ -113,15 +113,11 @@
     Command command =
         RemoteSpawnRunner.buildCommand(
             spawn.getOutputFiles(), spawn.getArguments(), spawn.getEnvironment(), platform);
-    Action action;
-    final ActionKey actionKey;
-    try (SilentCloseable c = Profiler.instance().profile("RemoteCache.buildAction")) {
-      action =
-          RemoteSpawnRunner.buildAction(
-              digestUtil.compute(command), merkleTreeRoot, context.getTimeout(), true);
-      // Look up action cache, and reuse the action output if it is found.
-      actionKey = digestUtil.computeActionKey(action);
-    }
+    Action action =
+        RemoteSpawnRunner.buildAction(
+            digestUtil.compute(command), merkleTreeRoot, context.getTimeout(), true);
+    // Look up action cache, and reuse the action output if it is found.
+    ActionKey actionKey = digestUtil.computeActionKey(action);
 
     Context withMetadata =
         TracingMetadataUtils.contextWithMetadata(buildRequestId, commandId, actionKey);

src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java

diff --git a/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java b/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java
index 9b489d1..20612aa 100644
--- a/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java
+++ b/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java
@@ -156,23 +156,17 @@
     Platform platform =
         parsePlatform(spawn.getExecutionPlatform(), remoteOptions.remoteDefaultPlatformProperties);
 
-    final Command command;
-    final Digest commandHash;
-    final Action action;
-    final ActionKey actionKey;
-    try (SilentCloseable c = Profiler.instance().profile("Remote.buildAction")) {
-      command =
-          buildCommand(
-              spawn.getOutputFiles(), spawn.getArguments(), spawn.getEnvironment(), platform);
-      commandHash = digestUtil.compute(command);
-      action =
-          buildAction(
-              commandHash,
-              merkleTree.getRootDigest(),
-              context.getTimeout(),
-              Spawns.mayBeCached(spawn));
-      actionKey = digestUtil.computeActionKey(action);
-    }
+    Command command =
+        buildCommand(
+            spawn.getOutputFiles(), spawn.getArguments(), spawn.getEnvironment(), platform);
+    Digest commandHash = digestUtil.compute(command);
+    Action action =
+        buildAction(
+            commandHash,
+            merkleTree.getRootDigest(),
+            context.getTimeout(),
+            Spawns.mayBeCached(spawn));
+    ActionKey actionKey = digestUtil.computeActionKey(action);
 
     // Look up action cache, and reuse the action output if it is found.
     Context withMetadata =