commit 5586fc186d42679d4fff41367e7039c966a176a7
author Laszlo Csomor <laszlocsomor@google.com> Thu Apr 11 05:02:42 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Apr 11 05:03:48 2019 -0700
tree 47bc685278f72ec81761d50aac5c4a3aea2013cc
parent 84a2c3b14af126d93b0207375fb08d9398602555

Bootstrap: report missing bintools early

The bootstrap script now begins with verifying
that all required tools are on the PATH, and fails
otherwise.

Previously, the bootstrap script could have spent
minutes working before it tried to use a missing
tool, only then reporting the absence.

This PR alleviates https://github.com/bazelbuild/bazel/issues/7641

Change-Id: I4c090113fe486f9dff9445adc703c76043088095

Closes #7991.

Change-Id: I5b9e3fbd8ae46fe2b74983305521b6385d82bc56
PiperOrigin-RevId: 243047535

scripts/bootstrap/buildenv.sh

diff --git a/scripts/bootstrap/buildenv.sh b/scripts/bootstrap/buildenv.sh
index 65b8d39..f5ee696 100755
--- a/scripts/bootstrap/buildenv.sh
+++ b/scripts/bootstrap/buildenv.sh
@@ -18,6 +18,36 @@
 
 set -o errexit
 
+# Check if all necessary tools are available.
+# List: https://github.com/bazelbuild/bazel/issues/7641#issuecomment-472344261
+for tool in basename cat chmod comm cp dirname find grep ln ls mkdir mktemp \
+            readlink rm sed sort tail touch tr uname unzip which; do
+  if ! hash "$tool" >/dev/null; then
+    echo >&2 "ERROR: cannot find \"$tool\"; check your PATH."
+    echo >&2 "       You may need to run the following command or similar:"
+    echo >&2 "         export PATH=\"/bin:/usr/bin:\$PATH\""
+    exit 1
+  fi
+done
+
+# Ensure Python is on the PATH on Windows, otherwise we would see
+# "LAUNCHER ERROR" messages from py_binary exe launchers.
+case "$(uname -s | tr "[:upper:]" "[:lower:]")" in
+msys*|mingw*|cygwin*)
+  # Ensure Python is on the PATH, otherwise the bootstrapping fails later.
+  if ! hash python.exe >/dev/null; then
+    echo >&2 "ERROR: cannot locate python.exe; check your PATH."
+    echo >&2 "       You may need to run the following command, or something"
+    echo >&2 "       similar, depending on where you installed Python:"
+    echo >&2 "         export PATH=\"/c/Python27:\$PATH\""
+    exit 1
+  fi
+  # Ensure TMPDIR uses the user-specified TMPDIR or TMP or TEMP.
+  # This is necessary to avoid overly longs paths during bootstrapping, see for
+  # example https://github.com/bazelbuild/bazel/issues/4536
+  export TMPDIR="${TMPDIR:-${TMP:-${TEMP:-}}}"
+esac
+
 # If BAZEL_WRKDIR is set, default all variables to point into
 # that directory