Allow SkyQueryEnvironment to be responsible for reporting missing deps or deps in error rather than the deps visitor classes.
Properly report errors in the SkyQuery bounded deps implementation to make it consistent with unbounded deps implementations where the query is considered to be in error with an appropriate message.
PiperOrigin-RevId: 291768034
diff --git a/src/main/java/com/google/devtools/build/lib/query2/ParallelSkyQueryUtils.java b/src/main/java/com/google/devtools/build/lib/query2/ParallelSkyQueryUtils.java
index dbc4354..24267e0 100644
--- a/src/main/java/com/google/devtools/build/lib/query2/ParallelSkyQueryUtils.java
+++ b/src/main/java/com/google/devtools/build/lib/query2/ParallelSkyQueryUtils.java
@@ -119,7 +119,7 @@
aggregateAllCallback)
.create();
visitor.visitAndWaitForCompletion(
- SkyQueryEnvironment.makeTransitiveTraversalKeysStrict(universeValue));
+ SkyQueryEnvironment.makeLabelsStrict(universeValue));
return Predicates.in(aggregateAllCallback.getResult());
});
};
@@ -162,12 +162,13 @@
QueryExpression expression,
QueryExpressionContext<Target> context,
Callback<Target> callback,
- boolean depsNeedFiltering) {
+ boolean depsNeedFiltering,
+ QueryExpression caller) {
return env.eval(
expression,
context,
ParallelVisitorUtils.createParallelVisitorCallback(
- new DepsUnboundedVisitor.Factory(env, callback, depsNeedFiltering, context)));
+ new DepsUnboundedVisitor.Factory(env, callback, depsNeedFiltering, context, caller)));
}
static class DepAndRdep {
