commit 56eb80b11f475a2e5b6e8803aeb3cf2294e329b4
author gregce <gregce@google.com> Wed May 02 09:04:10 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Wed May 02 09:05:50 2018 -0700
tree 419bbbd487fbe9b2555713ca3a1cd9d268796d5f
parent d61a185de8582d29dda7525bb04d8ffc5be3bd11

Simplify config fragment creation.

Remove all unnecessesary accesses to ConfigurationEnvironment and
deprecate the accesses that actually need ConfigurationEnvironment.

For review, check out ConfigurationFragmentFactory first.

PiperOrigin-RevId: 195099768

src/main/java/com/google/devtools/build/lib/analysis/ShellConfiguration.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/ShellConfiguration.java b/src/main/java/com/google/devtools/build/lib/analysis/ShellConfiguration.java
index df2e5f1..a76290d 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/ShellConfiguration.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/ShellConfiguration.java
@@ -18,7 +18,6 @@
 import com.google.devtools.build.lib.analysis.config.BuildConfiguration;
 import com.google.devtools.build.lib.analysis.config.BuildConfiguration.Fragment;
 import com.google.devtools.build.lib.analysis.config.BuildOptions;
-import com.google.devtools.build.lib.analysis.config.ConfigurationEnvironment;
 import com.google.devtools.build.lib.analysis.config.ConfigurationFragmentFactory;
 import com.google.devtools.build.lib.analysis.config.FragmentOptions;
 import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec;
@@ -100,7 +99,7 @@
 
     @Nullable
     @Override
-    public Fragment create(ConfigurationEnvironment env, BuildOptions buildOptions) {
+    public Fragment create(BuildOptions buildOptions) {
         return new ShellConfiguration(shellExecutableProvider.getShellExecutable(buildOptions));
     }