commit 573807d4e9d1b7a8b6956278773dfc53b544093f
author janakr <janakr@google.com> Thu Jan 11 14:02:35 2018 -0800
committer Copybara-Service <copybara-piper@google.com> Thu Jan 11 14:04:37 2018 -0800
tree ce89c3a760afbb113f78621a2b1ef0cbb9cef5e5
parent 42623f59fdd3bfbdfc21490c69f21537fa32011c

Convert ActionLookupKey implementations to directly implement SkyKey, removing the layer of indirection of getting SkyKey out of ActionLookupKey, which uses more memory for no reason.

PiperOrigin-RevId: 181658615

src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java
index a11e27a..fc4ebd6 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java
@@ -100,13 +100,13 @@
 
   @VisibleForTesting
   public static SkyKey key(Label label, BuildConfiguration configuration) {
-    return key(new ConfiguredTargetKey(label, configuration));
+    return ConfiguredTargetKey.of(label, configuration);
   }
 
   static ImmutableList<SkyKey> keys(Iterable<ConfiguredTargetKey> lacs) {
     ImmutableList.Builder<SkyKey> keys = ImmutableList.builder();
     for (ConfiguredTargetKey lac : lacs) {
-      keys.add(key(lac));
+      keys.add(lac);
     }
     return keys.build();
   }