commit 583db2d04f66b60858535cc3d98393760d2eb7d9
author ajurkowski <ajurkowski@google.com> Tue Dec 14 09:18:45 2021 -0800
committer Copybara-Service <copybara-worker@google.com> Tue Dec 14 09:20:06 2021 -0800
tree e83bfd50a582012cc5034593c80fe3f627141591
parent 58887b7fd2443f6dbcd7a22bb4c8e4d428464372

Remove unnecessary synchronization in `BazelBuildEventServiceModuleTest`.

This fixes occasional deadlocks in the test.

PiperOrigin-RevId: 416320729

src/test/java/com/google/devtools/build/lib/buildeventservice/BazelBuildEventServiceModuleTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/buildeventservice/BazelBuildEventServiceModuleTest.java b/src/test/java/com/google/devtools/build/lib/buildeventservice/BazelBuildEventServiceModuleTest.java
index ec9c6f0..22d9518 100644
--- a/src/test/java/com/google/devtools/build/lib/buildeventservice/BazelBuildEventServiceModuleTest.java
+++ b/src/test/java/com/google/devtools/build/lib/buildeventservice/BazelBuildEventServiceModuleTest.java
@@ -905,8 +905,14 @@
     @Nullable
     private String errorMessage = null;
 
+    /**
+     * Synchronizing this method can lead to deadlocks -- it calls into {@link
+     * io.grpc.inprocess.InProcessTransport} which takes a locks on itself. Opposite order of locks
+     * happens for {@link #publishBuildToolEventStream} called while holding the lock on {@link
+     * io.grpc.inprocess.InProcessTransport}.
+     */
     @Override
-    public synchronized void publishLifecycleEvent(
+    public void publishLifecycleEvent(
         PublishLifecycleEventRequest request, StreamObserver<Empty> responseObserver) {
       responseObserver.onNext(Empty.getDefaultInstance());
       responseObserver.onCompleted();