Fix new InstrumentationSpec for filegroup

This puts "srcs" under dependency_attributes instead of source_attributes, somewhat counter-intuitively:

1. "srcs" needs to be under dependency_attributes because filegroup just forwards FileProvider without any idea how the files are used. It doesn't know if the dependencies of stuff in srcs are runtime dependencies or not, so that needs to be forwarded indiscriminately and then dealt with by the consumer's InstrumentationSpec.

2. "srcs" needs to not be under source_attributes because source_attributes is for sources that this rule _processes_. filegroup doesn't process anything. (Previously, it needed to include source files it _directly included_ because it might have consumers using that legacy configuration, and in that case those consumers would never gather files from filegroup via FileProvider because it provided InstrumentedFilesProvider.)

RELNOTES: Make filegroup always forward InstrumentedFilesProvider and not collect any sources directly.
PiperOrigin-RevId: 323563516
1 file changed
tree: 536de3a9d035970b3e1bb5fa8a56ec9be8353afd
  1. .bazelci/
  2. examples/
  3. scripts/
  4. site/
  5. src/
  6. third_party/
  7. tools/
  8. .bazelrc
  9. .gitattributes
  10. .gitignore
  11. AUTHORS
  12. BUILD
  13. CHANGELOG.md
  14. CODEOWNERS
  15. combine_distfiles.py
  16. combine_distfiles_to_tar.sh
  17. compile.sh
  18. CONTRIBUTING.md
  19. CONTRIBUTORS
  20. distdir.bzl
  21. ISSUE_TEMPLATE.md
  22. LICENSE
  23. README.md
  24. WORKSPACE
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Contributing to Bazel

See CONTRIBUTING.md

Build status