| commit | 59245cac3d8853598666a6e1f93dd4efd1cc0ca1 | [log] [tgz] |
|---|---|---|
| author | Googler <noreply@google.com> | Mon Dec 02 15:44:53 2019 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Dec 02 15:46:08 2019 -0800 |
| tree | 79c97eeeb8b4d1f29ba7b8ae93edfc9766059910 | |
| parent | baf2838f69c5304f308ffaf62b0a03aa1fd553b8 [diff] |
bazel syntax: support struct.to_{json,proto} bound method
github.com/bazelbuild/bazel/pull/8931 was an incomplete fix to b/21392896:
it allowed 'x.f()' to be expressed as 'y=x.f; y()' in most cases, but not all.
In particular, it did not address the to_json and to_proto methods of
structs (which we should get rid of, BTW). This change is an ad-hoc fix for
those two methods. A more principled fix will have to wait till an integrated
clean-up of Info/StructImpl/NativeInfo.
This change is a prerequisite for fixing github.com/bazelbuild/bazel/issues/10339,
which is in turn a prerequisite for various simplifications and optimizations to
Starlark's function calling mechanism.
I audited Google's .bzl corpus for cases where the three-argument
getattr(x, name, dflt) was called with either an arbitrary name or
a name obtained from dir(x) without filtering, and where subsequent
operations might change their behavior if given a bound method instead
of 'dflt'. This turned up only two locations, both easily fixed (CL 283224061).
PiperOrigin-RevId: 283433923
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
