commit 59a0e4f10bf037dcd4f257b2e21573fa1b690e93
author ccalvarin <ccalvarin@google.com> Fri Jun 30 16:01:36 2017 +0200
committer Marcel Hlopko <hlopko@google.com> Mon Jul 03 09:05:16 2017 +0200
tree de0608d43ac8fe4931787a63966091eb30d729e2
parent 30c35a2a447a9fc5e93a6a5849d9c8a480d99464

Enforce the new category and effect tags.

All options need to explicitly list their category and effect. If they are uncategorized, this makes the lack of information obvious. Remove defaults from the annotation to enforce this.

Also enforce the sanity check that no option should have UNKNOWN or NO_OP effects listed with other effect tags.

Includes some last default sets for options I missed in the previous mass-setting change, and some that were added since.

PiperOrigin-RevId: 160641861

src/test/java/com/google/devtools/common/options/TestOptions.java

diff --git a/src/test/java/com/google/devtools/common/options/TestOptions.java b/src/test/java/com/google/devtools/common/options/TestOptions.java
index 9e79e85..c73009b 100644
--- a/src/test/java/com/google/devtools/common/options/TestOptions.java
+++ b/src/test/java/com/google/devtools/common/options/TestOptions.java
@@ -247,6 +247,8 @@
   @Option(
     name = "test_expansion_function",
     defaultValue = "null",
+    documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
+    effectTags = {OptionEffectTag.NO_OP},
     expansionFunction = TestExpansionFunction.class
   )
   public Void testExpansionFunction;
@@ -264,6 +266,8 @@
   @Option(
     name = "test_void_expansion_function",
     defaultValue = "null",
+    documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
+    effectTags = {OptionEffectTag.NO_OP},
     expansionFunction = TestVoidExpansionFunction.class
   )
   public Void testVoidExpansionFunction;