| commit | 36374709a9a076fdd84f86dd57e4ae43471adf17 | [log] [tgz] |
|---|---|---|
| author | Googler <leba@google.com> | Tue May 02 07:15:18 2023 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue May 02 07:16:28 2023 -0700 |
| tree | 16665c0b64ee37b13a27f09f38030c39552a89e3 | |
| parent | 4c7baa254ba0918f57a7ebfc97f21c6c22a57579 [diff] |
[aquery] Also parallelize the output producer in case of --skyframe_state. The previous change (https://github.com/bazelbuild/bazel/commit/68702a7affc5bdd6bf924726c39a1cd4bae9de8b) left out this part. Also fix a concurrency bug with the parallel output. This scenario was possible before: ``` Main thread: queue.put(POISON_PILL) -> outputStream.flush() Consumer thread: <consumer printing stuff> -> queue.take(POISON_PILL) ``` What happened there was the outputStream being flushed (via close()) and the eventual closing of the AqueryOutputHandler while the consumer maybe still be going through the tasks in the queue. This would cause unexpected output from blaze. By forcing #stopConsumer to wait for the consumer to finish consuming the POISON_PILL, we can avoid this race condition. As POISON_PILL is guaranteed to be the last task, we can be sure that nothing's left to be printed in the output streams by the time we're done with #stopConsumer. PiperOrigin-RevId: 528773712 Change-Id: Iffc16d27223fdfb7c9d3329f9973593bfb4b2283
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
