commit 5c8a5f55b9bd2455ed6392f5f334a3b4669199e4
author gregce <gregce@google.com> Wed May 13 10:35:36 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Wed May 13 10:36:52 2020 -0700
tree 310fc6ecfcdbfa7b7988fcb31fcc9c6b112fedd0
parent 564137a8fa2785e24277a4f846abdffe1e0f0687

The great Skylark -> Starlark class migration:
  AppleSkylarkCommon
  ObjcProviderSkylarkConverters
  SkylarkTestingModule
  AspectValueKey.SkylarkAspectLoadingKey
  AspectValueKey.HostSkylarkAspectLoadingKey
  ErrorReadingSkylarkExtensionException
  SkylarkAspectFactory
  SkylarkModuleCycleReporter
  ToplevelSkylarkAspectFunction
  ToplevelSkylarkAspectFunction.LoadSkylarkAspectFunctionException
  SkylarkBuildApiGlobals
  AndroidSkylarkApiProviderApi
  SkylarkTestingModuleTest

PiperOrigin-RevId: 311357679

src/main/java/com/google/devtools/build/lib/analysis/ConfiguredAspect.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/ConfiguredAspect.java b/src/main/java/com/google/devtools/build/lib/analysis/ConfiguredAspect.java
index b48f7ca..b6bbc08 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/ConfiguredAspect.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/ConfiguredAspect.java
@@ -66,7 +66,7 @@
     this.actions = actions;
     this.providers = providers;
 
-    // Initialize every SkylarkApiProvider
+    // Initialize every StarlarkApiProvider
     for (int i = 0; i < providers.getProviderCount(); i++) {
       Object obj = providers.getProviderInstanceAt(i);
       if (obj instanceof StarlarkApiProvider) {
@@ -184,12 +184,12 @@
       return this;
     }
 
-    public Builder addSkylarkTransitiveInfo(String name, Object value) {
+    public Builder addStarlarkTransitiveInfo(String name, Object value) {
       providers.put(name, value);
       return this;
     }
 
-    public Builder addSkylarkDeclaredProvider(Info declaredProvider) throws EvalException {
+    public Builder addStarlarkDeclaredProvider(Info declaredProvider) throws EvalException {
       Provider constructor = declaredProvider.getProvider();
       if (!constructor.isExported()) {
         throw new EvalException(