| commit | f309e0fc7fefa5d597db0b2dec7762e5523b69e7 | [log] [tgz] |
|---|---|---|
| author | Googler <adgar@google.com> | Thu Jul 27 10:17:24 2023 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Jul 27 10:18:40 2023 -0700 |
| tree | 2a4af31f57468773b1a2041319f5690df4bff8c2 | |
| parent | c061e57a7004a88eeb2f84d094d9a88b56c146b6 [diff] |
Add `CrashContext.haltOrReturnIfCrashInProgress()` for background threads that may deadlock when reporting a crash. It is possible to configure a background thread to report failures and crash Bazel which provides greater insight into crashes that may otherwise go unnoticed. Since BugReport#handleCrash() holds a global lock to report crashes with consistent details, an async thread crashing concurrently may block until a concurrent crash completes. Depending on when those async threads are joined, deadlock can occur. In particular, if a module waits for its async threads to shutdown before returning, deadlock happens while the first crash is tearing down each `BlazeModule`. A new `CrashContext.haltOrReturnIfCrashInProgress()` provides an option for such background threads: this `CrashContext` behaves exactly like `CrashContext.halt()` *unless a crash is already in progress*, in which case it behaves as a no-op. PiperOrigin-RevId: 551568672 Change-Id: Ide9adc77696bfdc62cabb5ed44cdc2fd11db6897
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
