Add missing tests for actions whose inputs do not change
The testActionWithNonChangingInput test never ran, because it was
parameterized and was missing @Test. The intent was to assert that
actions do not reexecute when their inputs are not dirtied, regardless
of whether the action is configured to "executeUnconditionally" or has
"isVolatile" equal to true.
Similar neighboring tests assert action behavior under different
circumstances, like when its input artifact's mtime or mtime-and-content
change.
RELNOTES: None.
PiperOrigin-RevId: 210744214
diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/SkyframeAwareActionTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/SkyframeAwareActionTest.java
index 18f117f..e6f29ad 100644
--- a/src/test/java/com/google/devtools/build/lib/skyframe/SkyframeAwareActionTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skyframe/SkyframeAwareActionTest.java
@@ -541,7 +541,17 @@
: ExpectActionIs.DIRTIED_BUT_VERIFIED_CLEAN);
}
- public void testActionWithNonChangingInput(final boolean unconditionalExecution)
+ @Test
+ public void testCacheCheckingActionWithNonChangingInput() throws Exception {
+ assertActionWithNonChangingInput(/* unconditionalExecution */ false);
+ }
+
+ @Test
+ public void testCacheBypassingActionWithNonChangingInput() throws Exception {
+ assertActionWithNonChangingInput(/* unconditionalExecution */ true);
+ }
+
+ private void assertActionWithNonChangingInput(final boolean unconditionalExecution)
throws Exception {
// Assert that a simple, non-skyframe-aware action is executed only once
// if its input does not change at all between builds.
