| commit | bc884e14f16ab7d1f6729a0485dfc281239d16a5 | [log] [tgz] |
|---|---|---|
| author | brandjon <brandjon@google.com> | Fri May 22 10:24:37 2020 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri May 22 10:25:55 2020 -0700 |
| tree | 7ba46c9de0383f3c47194d8b4767ba3afc269327 | |
| parent | 7154be04665e2d957b2b38b624f50ff3d006fced [diff] |
Tighten the types of some of the machinery surrounding .bzl skyframe inlining Tighten SkyKey to StarlarkImportLookupValue.Key for the internal functions of StarlarkImportLookupFunction and its inlined (non-Skyframe) caller. This avoids all but one downcast to [...].Key, in compute(), as is expected. Note the naming convention for vars -- "SkyKey skyKey", but "StarlarkImportLookupFunction.Key key". Also eliminate a redundant case in PackageFunction#computeStarlarkImportMapWithInlining, at the expense of making the quick return path not self-evident; added a comment to compensate. This is refactoring work toward adding a new kind of .bzl loading context, for Bazel-internal .bzl files. Work toward #11437. RELNOTES: None PiperOrigin-RevId: 312840745
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
