commit 6192b8c8eb5f9164153ad63dbb99444551ba50a1
author ulfjack <ulfjack@google.com> Thu May 24 02:40:42 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Thu May 24 02:41:41 2018 -0700
tree 26214badbd4438923038b82bf79d2110908a2f6d
parent 8bbcccd8f86a9361dfbe3f562320d6575576948b

Refactor analysis failure reporting, report loading failures

Split the AnalysisFailureEvent into a legacy and a new variant; always post an
AnalysisFailureEvent, even if the legacy variant is not posted - this gives us
some coverage for loading failures.

PiperOrigin-RevId: 197862257

src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java
index f22cf53..748451b 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java
@@ -847,11 +847,11 @@
       return loadingRootCauses;
     }
 
-    public Label getAnalysisRootCause() {
+    @Nullable public Label getAnalysisRootCause() {
       return analysisRootCause;
     }
 
-    public BuildEventId getConfiguration() {
+    @Nullable public BuildEventId getConfiguration() {
       return configuration;
     }
   }