| commit | 62387061cdbc6195df13d064531677447908baf6 | [log] [tgz] |
|---|---|---|
| author | adonovan <adonovan@google.com> | Mon Jan 11 15:41:13 2021 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Jan 11 15:42:21 2021 -0800 |
| tree | a0151fe76d80292d390b800cffe36122749dbf60 | |
| parent | 8c080d5295cdd8b8a4e62c5a8a731ae8d5affddd [diff] |
bazel analysis: preparatory cleanup to SRCTU error reporting This change causes the error handling logic in StarlarkRuleConfiguredTargetUtil (SRCTU) to avoid the EvalException(Location) constructor. Instead, the auxiliary location, if any, of provider instantiation is simply prepended to the error message (see the infoError function) in anticipation of being printed after a newline. For example: ERROR p/BUILD:1:1:\n foo.bzl:1:2: <provider-related message> createTarget uses a distinct exception, BadImplementationFunction, for errors that arise not from the Starlark implementation function but from the post-processing of the providers. A follow-up change will replace this exception by directly reporting events to the handler, thus permitting both higher quality structured errors capable of reporting more than one relevant location, and multiple errors in a single pass. However, that change is too tricky to accomplish in this CL. Also: - move "advertised provider" and "orphaned file" checks into createTarget. - add comments to document this particularly painful code. - delete EvalException.getDeprecatedLocation. PiperOrigin-RevId: 351251301
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
