commit 62dfdf57d63fa343d0191a917502861759888147
author janakr <janakr@google.com> Mon Jan 07 13:32:55 2019 -0800
committer Copybara-Service <copybara-piper@google.com> Mon Jan 07 13:34:48 2019 -0800
tree 6d639e84041f31e1c97f77169c0ad5987f1b109e
parent 3af93c9c4cc820a6848f3d774a82eebf69f04e16

Make PackageLookupFunction hermetic. It was only non-hermetic because of deleted packages, and we can just aggressively delete the nodes in that case.

PiperOrigin-RevId: 228225515

src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java
index ae534ae..7673297 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java
@@ -38,9 +38,10 @@
       SkyFunctionName.createHermetic("FILE_SYMLINK_INFINITE_EXPANSION_UNIQUENESS");
   public static final SkyFunctionName DIRECTORY_LISTING =
       SkyFunctionName.createHermetic("DIRECTORY_LISTING");
-  // Non-hermetic because unfortunately package lookups secretly access the set of deleted packages.
+  // Hermetic even though package lookups secretly access the set of deleted packages, becaused
+  // SequencedSkyframeExecutor deletes any affected PACKAGE_LOOKUP nodes when that set changes.
   public static final SkyFunctionName PACKAGE_LOOKUP =
-      SkyFunctionName.createNonHermetic("PACKAGE_LOOKUP");
+      SkyFunctionName.createHermetic("PACKAGE_LOOKUP");
   public static final SkyFunctionName CONTAINING_PACKAGE_LOOKUP =
       SkyFunctionName.createHermetic("CONTAINING_PACKAGE_LOOKUP");
   // Non-hermetic because accesses the package locator. Also does disk access.