commit 64c6632d95e1f9ccf55e7268d71215ef5ce38c84
author brandjon <brandjon@google.com> Wed Aug 23 04:36:38 2017 +0200
committer Damien Martin-Guillerez <dmarting@google.com> Wed Aug 23 13:31:45 2017 +0200
tree 67d7c6f0354f86c09247244f21a1ec40b58b6be3
parent c1934b827e91a47ba4fe18baad4be6d46807de41

Minor refactor of UserDefinedFunction constructor, accessors

RELNOTES: None
PiperOrigin-RevId: 166149340

src/main/java/com/google/devtools/build/lib/syntax/UserDefinedFunction.java

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/UserDefinedFunction.java b/src/main/java/com/google/devtools/build/lib/syntax/UserDefinedFunction.java
index f585068..6dae713 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/UserDefinedFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/UserDefinedFunction.java
@@ -16,6 +16,7 @@
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.Iterables;
 import com.google.devtools.build.lib.cmdline.Label;
+import com.google.devtools.build.lib.events.Location;
 import com.google.devtools.build.lib.profiler.Profiler;
 import com.google.devtools.build.lib.profiler.ProfilerTask;
 import com.google.devtools.build.lib.skylarkinterface.SkylarkPrinter;
@@ -31,23 +32,24 @@
   // we close over the globals at the time of definition
   private final Environment.Frame definitionGlobals;
 
-  protected UserDefinedFunction(
-      Identifier function,
+  public UserDefinedFunction(
+      String name,
+      Location loc,
       FunctionSignature.WithValues<Object, SkylarkType> signature,
       ImmutableList<Statement> statements,
       Environment.Frame definitionGlobals)
       throws EvalException {
-    super(function.getName(), signature, function.getLocation());
+    super(name, signature, loc);
     this.statements = statements;
     this.definitionGlobals = definitionGlobals;
   }
 
-  public FunctionSignature.WithValues<Object, SkylarkType> getFunctionSignature() {
-    return signature;
+  public ImmutableList<Statement> getStatements() {
+    return statements;
   }
 
-  ImmutableList<Statement> getStatements() {
-    return statements;
+  public Environment.Frame getDefinitionGlobals() {
+    return definitionGlobals;
   }
 
   @Override