Replace calls to <class>.newInstance with <class>.getConstructor().newInstance. This is safer; newInstance on class objects bypasses exception checking. -- MOS_MIGRATED_REVID=129976805
diff --git a/src/main/java/com/google/devtools/build/docgen/RuleDocumentationAttribute.java b/src/main/java/com/google/devtools/build/docgen/RuleDocumentationAttribute.java index 02357ff..41091af 100644 --- a/src/main/java/com/google/devtools/build/docgen/RuleDocumentationAttribute.java +++ b/src/main/java/com/google/devtools/build/docgen/RuleDocumentationAttribute.java
@@ -23,7 +23,6 @@ import com.google.devtools.build.lib.packages.BuildType; import com.google.devtools.build.lib.packages.TriState; import com.google.devtools.build.lib.syntax.Type; - import java.util.HashMap; import java.util.LinkedList; import java.util.Map; @@ -258,8 +257,8 @@ ConfiguredRuleClassProvider ruleClassProvider) { if (ruleClassProvider == null) { try { - return usingClass.newInstance(); - } catch (IllegalAccessException | InstantiationException e) { + return usingClass.getConstructor().newInstance(); + } catch (ReflectiveOperationException | IllegalArgumentException e) { throw new IllegalStateException(e); } }