commit 658662136e65f54f93a0c81c7fb78dd6b46b55a6
author janakr <janakr@google.com> Sat Mar 10 22:30:33 2018 -0800
committer Copybara-Service <copybara-piper@google.com> Sat Mar 10 22:32:11 2018 -0800
tree 3cd15c895a3e93065e8f9bccc671f1e6c9df64ec
parent 0758d35eedacf5e367fe56a7ae006d3b2ff9c3fb

Add RuleContext#getConfiguredTargetAndDataMap and use it in analysis/Util.

PiperOrigin-RevId: 188629293

src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java b/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java
index 8a62dd2..6bab955 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java
@@ -375,6 +375,14 @@
     return Multimaps.transformValues(targetMap, ConfiguredTargetAndData::getConfiguredTarget);
   }
 
+  /**
+   * Returns an immutable map from attribute name to list of {@link ConfiguredTargetAndData} objects
+   * for that attribute.
+   */
+  public ListMultimap<String, ConfiguredTargetAndData> getConfiguredTargetAndDataMap() {
+    return targetMap;
+  }
+
   private List<ConfiguredTargetAndData> getConfiguredTargetAndTargetDeps(String key) {
     return targetMap.get(key);
   }

src/main/java/com/google/devtools/build/lib/analysis/Util.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/Util.java b/src/main/java/com/google/devtools/build/lib/analysis/Util.java
index 02d05b5..e379ffc 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/Util.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/Util.java
@@ -22,6 +22,7 @@
 import com.google.devtools.build.lib.collect.compacthashset.CompactHashSet;
 import com.google.devtools.build.lib.packages.AttributeMap;
 import com.google.devtools.build.lib.packages.Target;
+import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData;
 import com.google.devtools.build.lib.skyframe.ConfiguredTargetKey;
 import com.google.devtools.build.lib.vfs.PathFragment;
 import java.util.List;
@@ -83,10 +84,10 @@
     Set<ConfiguredTargetKey> maybeImplicitDeps = CompactHashSet.create();
     Set<ConfiguredTargetKey> explicitDeps = CompactHashSet.create();
     AttributeMap attributes = ruleContext.attributes();
-    ListMultimap<String, ? extends TransitiveInfoCollection> targetMap =
-        ruleContext.getConfiguredTargetMap();
+    ListMultimap<String, ConfiguredTargetAndData> targetMap =
+        ruleContext.getConfiguredTargetAndDataMap();
     for (String attrName : attributes.getAttributeNames()) {
-      List<? extends TransitiveInfoCollection> attrValues = targetMap.get(attrName);
+      List<ConfiguredTargetAndData> attrValues = targetMap.get(attrName);
       if (attrValues != null && !attrValues.isEmpty()) {
         if (attributes.isAttributeValueExplicitlySpecified(attrName)) {
           addLabelsAndConfigs(explicitDeps, attrValues);
@@ -111,8 +112,11 @@
   }
 
   private static void addLabelsAndConfigs(
-      Set<ConfiguredTargetKey> set, List<? extends TransitiveInfoCollection> deps) {
+      Set<ConfiguredTargetKey> set, List<ConfiguredTargetAndData> deps) {
     deps.forEach(
-        target -> set.add(ConfiguredTargetKey.of(target.getLabel(), target.getConfiguration())));
+        target ->
+            set.add(
+                ConfiguredTargetKey.of(
+                    target.getConfiguredTarget().getLabel(), target.getConfiguration())));
   }
 }