commit 667f3c9dd16157678deb19da2340e70ce50bd2a2
author shreyax <shreyax@google.com> Mon Oct 25 12:32:22 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Oct 25 12:34:02 2021 -0700
tree 299afdf13e836e767e36643670809e7c89dc3055
parent 6ca18dbfe08e57253074157fcd6d879e88747dc1

Fix comments regarding rpackages when a file has no ancestor BUILD file

PiperOrigin-RevId: 405464912

src/main/java/com/google/devtools/build/lib/query2/RBuildFilesVisitor.java

diff --git a/src/main/java/com/google/devtools/build/lib/query2/RBuildFilesVisitor.java b/src/main/java/com/google/devtools/build/lib/query2/RBuildFilesVisitor.java
index eb292f9..6e5efa3 100644
--- a/src/main/java/com/google/devtools/build/lib/query2/RBuildFilesVisitor.java
+++ b/src/main/java/com/google/devtools/build/lib/query2/RBuildFilesVisitor.java
@@ -173,6 +173,9 @@
    * of SkyKeys whose transitive reverse dependencies must contain the exact same set of packages.
    *
    * <p>Note that there may not be nodes in the graph corresponding to the returned SkyKeys.
+   *
+   * <p>Note also that we assume there'll be a PackageLookupValue node for some ancestor directory
+   * of every file to which a symlink could possibly point otherwise the file will not be included.
    */
   private static Collection<SkyKey> getSkyKeysForFileFragments(
       WalkableGraph graph, Iterable<PathFragment> pathFragments) throws InterruptedException {