commit 66a1038a128fbde9331598580f57afb513e4fa36
author Googler <tjgq@google.com> Mon Oct 28 09:59:01 2024 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Oct 28 10:01:20 2024 -0700
tree 10f40a81358159642aa7382e33ab5623965d2989
parent 374658377f662701f1e92f757090949fdd0da1ab

Implement File.is_symlink.

For symmetry with File.is_directory.

Fixes #11209.

PiperOrigin-RevId: 690652872
Change-Id: I4e93cb18e2469819cfa46f3c0685376093fc455e

src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkCustomCommandLine.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkCustomCommandLine.java b/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkCustomCommandLine.java
index 88808bd..76d663d 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkCustomCommandLine.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkCustomCommandLine.java
@@ -1341,6 +1341,11 @@
     }
 
     @Override
+    public boolean isSymlink() {
+      return false;
+    }
+
+    @Override
     public String getRunfilesPathString() {
       PathFragment relativePath = execPath.relativeTo(fileset.getExecPath());
       return fileset.getRunfilesPath().getRelative(relativePath).getPathString();

src/main/java/com/google/devtools/build/lib/starlarkbuildapi/FileApi.java

diff --git a/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/FileApi.java b/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/FileApi.java
index 90b5700..4a3bd83 100644
--- a/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/FileApi.java
+++ b/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/FileApi.java
@@ -90,10 +90,22 @@
   @StarlarkMethod(
       name = "is_directory",
       structField = true,
-      doc = "Returns true if this is a directory.")
+      doc =
+          "Returns true if this is a directory. This reflects the type the file was declared as"
+              + " (i.e. ctx.actions.declare_directory), not its type on the filesystem, which might"
+              + " differ.")
   boolean isDirectory();
 
   @StarlarkMethod(
+      name = "is_symlink",
+      structField = true,
+      doc =
+          "Returns true if this is a directory. This reflects the type the file was declared as"
+              + " (i.e. ctx.actions.declare_symlink), not its type on the filesystem, which might"
+              + " differ.")
+  boolean isSymlink();
+
+  @StarlarkMethod(
       name = "short_path",
       structField = true,
       doc =