commit 66dac668159c23eb0e32eb10d30491d073ed4479
author pcloudy <pcloudy@google.com> Tue Nov 05 05:03:20 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Tue Nov 05 05:04:26 2019 -0800
tree 91c959fd2b1f4879446f564edee31bd196b871f5
parent 9131dbefbc08500219abdc48db84270a9696ab8e

Add test for TestStrategy.getTmpDirName

To make sure the length of tmp dir name doesn't change unexpected.

RELNOTES: None
PiperOrigin-RevId: 278599465

src/test/java/com/google/devtools/build/lib/exec/StandaloneTestStrategyTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/exec/StandaloneTestStrategyTest.java b/src/test/java/com/google/devtools/build/lib/exec/StandaloneTestStrategyTest.java
index 1aeb07c..f866227 100644
--- a/src/test/java/com/google/devtools/build/lib/exec/StandaloneTestStrategyTest.java
+++ b/src/test/java/com/google/devtools/build/lib/exec/StandaloneTestStrategyTest.java
@@ -188,6 +188,26 @@
   }
 
   @Test
+  public void testCreateTmpDirForTest() throws Exception {
+    // setup a test action
+    scratch.file("standalone/simple_test.sh", "this does not get executed, it is mocked out");
+    scratch.file(
+        "standalone/BUILD",
+        "sh_test(",
+        "    name = \"simple_test\",",
+        "    size = \"small\",",
+        "    srcs = [\"simple_test.sh\"],",
+        ")");
+    TestRunnerAction testRunnerAction = getTestAction("//standalone:simple_test");
+
+    String tmpDirName = TestStrategy.getTmpDirName(testRunnerAction);
+    // Make sure the length of tmpDirName doesn't change unexpectedy: it cannot be too long
+    // because Windows and macOS have limitations on file path length.
+    // Note: It's OK to update 32 to a smaller number if tmpDirName gets shorter.
+    assertThat(tmpDirName.length()).isEqualTo(32);
+  }
+
+  @Test
   public void testRunTestOnce() throws Exception {
     ExecutionOptions executionOptions = ExecutionOptions.DEFAULTS;
     Path tmpDirRoot = TestStrategy.getTmpRoot(rootDirectory, outputBase, executionOptions);