commit 6874316e27af4074ad98b361e050b1aa13b5611b
author Laurent Le Brun <laurentlb@google.com> Wed May 13 13:18:09 2015 +0000
committer Damien Martin-Guillerez <dmarting@google.com> Fri May 15 09:43:37 2015 +0000
tree d3e3d10b56b5a72931f19cbd7a22750830ab8ec9
parent 463508baa66aa93785b7b3ccf4764cca765e32c6

Skylark: Functions don't need to be declared in order.

--
MOS_MIGRATED_REVID=93515487

src/test/java/com/google/devtools/build/lib/syntax/ValidationTests.java

diff --git a/src/test/java/com/google/devtools/build/lib/syntax/ValidationTests.java b/src/test/java/com/google/devtools/build/lib/syntax/ValidationTests.java
index edbf550..fbbdbcc 100644
--- a/src/test/java/com/google/devtools/build/lib/syntax/ValidationTests.java
+++ b/src/test/java/com/google/devtools/build/lib/syntax/ValidationTests.java
@@ -107,14 +107,14 @@
 
   @Test
   public void testFunctionDefRecursion() throws Exception {
-    checkError("function 'func' does not exist",
+    parse(
         "def func():",
         "  func()\n");
   }
 
   @Test
   public void testMutualRecursion() throws Exception {
-    checkError("function 'bar' does not exist",
+    parse(
         "def foo(i):",
         "  bar(i)",
         "def bar(i):",
@@ -123,13 +123,19 @@
   }
 
   @Test
-  public void testFunctionDoesNotExistInFunctionDef() {
-    checkError("function 'foo' does not exist",
+  public void testFunctionDefinedBelow() {
+    parse(
         "def bar(): a = foo() + 'a'",
         "def foo(): return 1\n");
   }
 
   @Test
+  public void testFunctionDoesNotExist() {
+    checkError("function 'foo' does not exist",
+        "def bar(): a = foo() + 'a'");
+  }
+
+  @Test
   public void testStructMembersAreImmutable() {
     checkError("can only assign to variables and tuples, not to 's.x'",
         "s = struct(x = 'a')",