commit 6d9ca5b5bf1854c39bc88419345976d277a720cf
author Janak Ramakrishnan <janakr@google.com> Mon Aug 31 19:22:06 2015 +0000
committer Kristina Chodorow <kchodorow@google.com> Mon Aug 31 21:06:26 2015 +0000
tree c0a9f3980ed96a9a3d99163c3abf02749b6b56d8
parent 2ae29debaea7e59897e19e671fb1f7ec94f97648

Prefetch children of node being checked for cycles, in case graph implementation caches batched results.

--
MOS_MIGRATED_REVID=101961270

src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java
index 2a5a8c8..6ddd647 100644
--- a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java
+++ b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java
@@ -1505,10 +1505,12 @@
       }
 
       // This node is not yet known to be in a cycle. So process its children.
-      Iterable<? extends SkyKey> children = entry.getTemporaryDirectDeps();
+      Iterable<SkyKey> children = entry.getTemporaryDirectDeps();
       if (Iterables.isEmpty(children)) {
         continue;
       }
+      // Prefetch all children, in case our graph performs better with a primed cache.
+      graph.getBatch(children);
 
       // This marker flag will tell us when all this node's children have been processed.
       toVisit.push(CHILDREN_FINISHED);