commit 6da8982d997c119c548881aa6d7db736b9dd07d0
author ulfjack <ulfjack@google.com> Mon Feb 04 13:06:34 2019 -0800
committer Copybara-Service <copybara-piper@google.com> Mon Feb 04 13:08:41 2019 -0800
tree 4b558def9522e2a85063a5576efedf6c7480d889
parent 60dcd828f16f6757aab89d30a5cb19bac182ef98

Default --experimental_split_xml_generation to true

This changes the test action to generate the xml file as a separate step
if the test itself did not generate an xml file in the first place. The
reason for this change is a race condition in Posix-style operating
systems when piping output to stdout and to a file simultaneously.

Fixes #4608.

RELNOTES: For tests that do not generate a test.xml, Bazel now uses a separate action to generate one; this results in minor differences in the generated test.xml, and makes the generation more reliable overall.
PiperOrigin-RevId: 232351927

src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java

diff --git a/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java b/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java
index df7eef4..c8444fd 100644
--- a/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java
+++ b/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java
@@ -416,14 +416,14 @@
   public String executionLogFile;
 
   @Option(
-    name = "experimental_split_xml_generation",
-    defaultValue = "false",
-    documentationCategory = OptionDocumentationCategory.EXECUTION_STRATEGY,
-    effectTags = {OptionEffectTag.EXECUTION},
-    help = "If this flag is set, and a test action does not generate a test.xml file, then "
-        + "Bazel uses a separate action to generate a dummy test.xml file containing the test log. "
-        + "Otherwise, Bazel generates the test.xml as part of the test action."
-  )
+      name = "experimental_split_xml_generation",
+      defaultValue = "true",
+      documentationCategory = OptionDocumentationCategory.EXECUTION_STRATEGY,
+      effectTags = {OptionEffectTag.EXECUTION},
+      help =
+          "If this flag is set, and a test action does not generate a test.xml file, then "
+              + "Bazel uses a separate action to generate a dummy test.xml file containing the "
+              + "test log. Otherwise, Bazel generates a test.xml as part of the test action.")
   public boolean splitXmlGeneration;
 
   /** Converter for the --flaky_test_attempts option. */