| commit | 3ea75594bfdb5e6794250155995c45a5adc00c28 | [log] [tgz] |
|---|---|---|
| author | janakr <janakr@google.com> | Wed Aug 04 09:30:54 2021 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Aug 04 09:32:19 2021 -0700 |
| tree | cb4652e78943d2f1623597ce328dabbda08baa30 | |
| parent | d0d0c5fa8652ee6232f93b133db61d1456034cb2 [diff] |
Optimize some parts of Skyframe node deletion, especially for the case of discarding the analysis cache on a configuration change: 1. Avoid processing to-be-deleted direct deps of a node being deleted: removing this node from the dep's reverse deps is useful only as a consistency check and is too expensive to justify, given that it's been a long time since there was a bug there. 2. To make (1) more effective, in an analysis-cache-discarding event, eagerly mark all ActionLookupData nodes as to-be-deleted: they will be deleted anyway, since they depend on ActionLookupKey nodes, and marking them eagerly means we can apply the optimization in (1). 3. Don't make an ImmutableSet copy of the reverse deps in ReverseDepsUtility#getReverseDeps when the node is about to be deleted: the consistency check is not worth the cost. This should reduce CPU, memory churn, and contention. PiperOrigin-RevId: 388715102
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
