| commit | 6dc941e58dfc1d4a9714a76b921fbe11fce658ed | [log] [tgz] |
|---|---|---|
| author | pcloudy <pcloudy@google.com> | Thu May 06 08:44:28 2021 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu May 06 08:45:23 2021 -0700 |
| tree | 655575f3eb40fba580d28910369b953246363da1 | |
| parent | 762b5d840760690cafc40ddb65b56a8933350877 [diff] |
Remove restriction on generate_pdb_file to be only used in dbg and fastbuild mode Users may want to build in opt mode and still want the pdb file to be a linking action output. See https://github.com/bazelbuild/rules_cc/issues/94#issuecomment-828254895 RELNOTES: None PiperOrigin-RevId: 372351216
diff --git a/tools/cpp/windows_cc_toolchain_config.bzl b/tools/cpp/windows_cc_toolchain_config.bzl index 042d519..f43f8ba 100644 --- a/tools/cpp/windows_cc_toolchain_config.bzl +++ b/tools/cpp/windows_cc_toolchain_config.bzl
@@ -666,10 +666,6 @@ generate_pdb_file_feature = feature( name = "generate_pdb_file", - requires = [ - feature_set(features = ["dbg"]), - feature_set(features = ["fastbuild"]), - ], ) output_execpath_flags_feature = feature(